[-Wunsafe-buffer-usage] Check missing and duplicated assignments #11658
Conversation
Add checks for missing and duplicated assignments in bounds-attributed groups. This model requires each mutable decl in a group to be assigned exactly once. rdar://161608243
patrykstefanski
requested review from
delcypher,
hnrklssn,
rapidsna and
ziqingluo-90
patrykstefanski
added
the
clang:bounds-safety
There was a problem hiding this comment.
LGTM, thank you. Just have one nitpick.
Btw, is checking dependencies between assignments within one assignment group something we planned to do? For example,
void f(int * __counted_by(n) ptr, size_t n) {
ptr = span.first(n).data();
n = 42; // this assignment should happen first
}
| const llvm::SmallPtrSetImpl<const ValueDecl *> &Missing, | ||
| bool IsRelatedToDecl, ASTContext &Ctx) override { | ||
|
|
||
| llvm::SmallString<64> RequiredAssignments = DeclSetToStr(Required); |
There was a problem hiding this comment.
Another option could be using notes to list these objects that need to be assigned exactly once. Each Decl per note.
This way, we could make the warning message shorter and less parameterized (this benefits grep-ing warning messages), and provide more information in notes, e.g., adding " ... need to be assigned exactly once." and pointing to their source locations.
There was a problem hiding this comment.
Another option could be using notes to list these objects that need to be assigned exactly once. Each Decl per note. This way, we could make the warning message shorter and less parameterized (this benefits
grep-ing warning messages), and provide more information in notes, e.g., adding " ... need to be assigned exactly once." and pointing to their source locations.
As agreed, I'll file an issue/rdar and we can come back to this later.
|
@swift-ci test llvm |
Yes, this is going to be my next part. I already have this in my original PR: #11490 |
2 participants
Add checks for missing and duplicated assignments in bounds-attributed groups. This model requires each mutable decl in a group to be assigned exactly once.
rdar://161608243